aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrian Ashworth <bosrsf04@gmail.com>2019-02-05 08:35:00 -0500
committerDrew DeVault <sir@cmpwn.com>2019-02-11 10:15:00 -0500
commit0c091bed769b43089191d5f62cdd81ef399cfd98 (patch)
treebc3ed187e304d0bd2fa76d4bb2a8a6ef2a38cb08
parent9346ed1805dab798fe9f6edcb47e003081722d79 (diff)
downloadsway-0c091bed769b43089191d5f62cdd81ef399cfd98.zip
sway-0c091bed769b43089191d5f62cdd81ef399cfd98.tar.gz
sway-0c091bed769b43089191d5f62cdd81ef399cfd98.tar.bz2
cmd_workspace_gaps: fix double free on bad amount
This fixes a double free in cmd_workspace_gaps when the amount given is invalid. The end pointer from strtol is part of the argument and should not be freed. Freeing the end pointer could result in a double free or bad free depending on whether or not the end pointer was at the start of the argument
-rw-r--r--sway/commands/workspace.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/sway/commands/workspace.c b/sway/commands/workspace.c
index c5d6435..65a3f40 100644
--- a/sway/commands/workspace.c
+++ b/sway/commands/workspace.c
@@ -76,7 +76,6 @@ static struct cmd_results *cmd_workspace_gaps(int argc, char **argv,
char *end;
int amount = strtol(argv[gaps_location + 2], &end, 10);
if (strlen(end)) {
- free(end);
return cmd_results_new(CMD_FAILURE, expected);
}